Latest upgrade fixes/improvements #637
Draft
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although nil key can be caught by the caller, lib-side NPE is still bad in this case. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
changed the title
AssertAuthKey method on nil public key
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
==========================================
- Coverage 57.47% 57.46% -0.01%
==========================================
Files 164 164
Lines 22503 22503
==========================================
- Hits 12934 12932 -2
- Misses 9175 9176 +1
- Partials 394 395 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after lib upgrade within nspcc-dev/neofs-node#3005, some issues appeared nspcc-dev/neofs-node#3005 (comment). Here are insta fixes for them